fix: handle punkt_tab fallback in split_sentences for NLTK >= 3.9 - #1023
Open
danishashko wants to merge 2 commits into
Open
fix: handle punkt_tab fallback in split_sentences for NLTK >= 3.9#1023danishashko wants to merge 2 commits into
danishashko wants to merge 2 commits into
Conversation
dc-harsh
added a commit
to dc-harsh/newspaper
that referenced
this pull request
May 29, 2026
- requirements: add lxml-html-clean (fixes `import newspaper` breaking on lxml>=5) - nlp: NLTK punkt_tab fallback in split_sentences (codelucas#1023) + collapse intra-sentence newlines (codelucas#873); download_corpora adds punkt_tab (codelucas#1023) - cleaners: itemprop contains("articleBody") keeps multi-token itemprop nodes (codelucas#953) - extractors: include <article> in scoring candidate nodes (codelucas#865) - tests: expect precise meta article:published_time (intended fork behavior) - bump version to 0.4.0
pgwimberl71
reviewed
Jul 15, 2026
pgwimberl71
left a comment
pgwimberl71
left a comment
There was a problem hiding this comment.
1f6e1770c95468d862d86084d290aa8b0e8b5db71f6e1770c95468d862d86084d290aa8b0e8b5db7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1017
NLTK 3.9 moved the default punkt tokenizer from
tokenizers/punkt/english.pickletotokenizers/punkt_tab/english. On a fresh install with NLTK >= 3.9 onlypunkt_tabis downloaded, so callingsplit_sentences()raises aLookupErroreven when NLTK is properly installed.What this changes:
newspaper/nlp.py-split_sentences()now tries the old path first and falls back topunkt_tabif not found. Works with both old and new NLTK versions.download_corpora.py- addspunkt_tabtoREQUIRED_CORPORAso it gets downloaded alongsidepunkt.PR #1006 already adds
punkt_tabto the download list, but the runtime crash innlp.pystill happens if onlypunkt_tabis available. This fixes both.